gustavodemorais commented on PR #29579:
URL: https://github.com/apache/flink/pull/29579#issuecomment-6365006442
LGTM. Thanks, @raminqaf! I only have one small suggestion.
The new test only checks the generated code. A runtime assertion that
`parseJsonToVariant` throws the raw `IOException` (not a
`TableRuntimeException`) would catch a regression there:
```java
assertThatThrownBy(() ->
SqlJsonUtils.parseJsonToVariant(StringData.fromString("not json"), false))
.isInstanceOf(IOException.class)
.isNotInstanceOf(TableRuntimeException.class);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
