Savonitar commented on code in PR #335:
URL:
https://github.com/apache/flink-connector-kafka/pull/335#discussion_r4361589262
##########
flink-connector-kafka/src/test/java/org/apache/flink/connector/kafka/sink/KafkaSinkITCase.java:
##########
@@ -539,11 +538,7 @@ public void checkMigration(
clusterClient);
JobResult jobResult = clusterClient.requestJobResult(thirdJobId).get();
- assertThat(jobResult.getApplicationStatus())
- .isEqualTo(
- supportedMigration
- ? ApplicationStatus.SUCCEEDED
- : ApplicationStatus.FAILED);
+ assertThat(jobResult.isSuccess()).isEqualTo(supportedMigration);
Review Comment:
Does this replacement have same meaning or we make the assertion
weaker/stronger and accept that?
##########
flink-connector-kafka/src/test/java/org/apache/flink/streaming/connectors/kafka/table/KafkaTableTestBase.java:
##########
@@ -106,6 +107,17 @@ void after() {
cancelTimeoutLogger();
}
+ /**
+ * Since Flink 2.3 (FLIP-558), an insert whose upsert key differs from the
primary key of the
Review Comment:
The comment says "upsert", but I checked and it looks like some call sites
are append only **without** upsert keys. Is it intentional?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
