MartijnVisser commented on code in PR #310:
URL:
https://github.com/apache/flink-connector-kafka/pull/310#discussion_r4367947463
##########
flink-connector-kafka/src/test/java/org/apache/flink/connector/kafka/sink/FlinkKafkaInternalProducerITCase.java:
##########
@@ -159,6 +159,12 @@ void
testResetInnerTransactionIfFinalizingTransactionFailed(
fenced.initTransactions();
fenced.beginTransaction();
fenced.send(new ProducerRecord<>(topic, "test-value"));
+ // Await the produce before fencing. An in-flight ProduceRequest
that reaches the
+ // broker after the epoch bump below is rejected with
INVALID_PRODUCER_EPOCH, and the
+ // finalizer then throws InvalidProducerEpochException, a sibling
of
Review Comment:
I think this only holds for the commit finalizer: `beginAbort` skips the
abortable error, so abort still gets PRODUCER_FENCED from EndTxn. Maybe say
commit here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
