MartijnVisser opened a new pull request, #258:
URL: https://github.com/apache/flink-connector-jdbc/pull/258

   ## What is the purpose of the change
   
   After the end of input, the exactly-once `JdbcWriter` started a transaction 
on every checkpoint, so a second checkpoint before the task finished failed 
with "currentXid not null". FLINK-41060's new tests hit this, so it should land 
first.
   
   ## Brief change log
   
   - `JdbcWriter.snapshotState()` starts no transaction once the input ended
   
   ## Verifying this change
   
   This change added tests and can be verified as follows:
   
   - `ExactlyOnceJdbcWriterTest#testCheckpointsAfterEndOfInput`: fails on main
   
   ## Does this pull request potentially affect one of the following parts:
   
   - Dependencies (does it add or upgrade a dependency): no
   - The public API, i.e., is any changed class annotated with 
`@Public(Evolving)`: no
   - The serializers: no
   - The runtime per-record code paths (performance sensitive): no
   - Anything that affects deployment or recovery: JobManager (and its 
components), Checkpointing, Kubernetes/Yarn, ZooKeeper: yes
   - The S3 file system connector: no
   
   ## Documentation
   
   - Does this pull request introduce a new feature? no
   - If yes, how is the feature documented? not applicable
   
   ---
   
   ##### Was generative AI tooling used to co-author this PR?
   
   - [X] Yes (please specify the tool below)
   
   Generated-by: Claude Code (Claude Opus 5.5)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to