snuyanzin commented on code in PR #62:
URL:
https://github.com/apache/flink-connector-shared-utils/pull/62#discussion_r4371008472
##########
_utils.sh:
##########
@@ -59,9 +59,19 @@ function create_pristine_source {
}
function get_pom_version {
+ local version
+ local version_pattern='^[0-9]+(\.[0-9]+)*(-[0-9A-Za-z.]+)*$'
set +u
Review Comment:
if there is SHELLOPTS is omitted and added `${MVN}` now, do we still need
`set +u`, `set -u`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
