bharathgunapati commented on PR #57: URL: https://github.com/apache/flink-connector-http/pull/57#issuecomment-6400866012
Thanks for the reviews. Addressed in the latest push: - Legacy error-code behaviour documented on all four pages. - Two new tests for a flush split into several HTTP requests (batch size and method change), see the thread above for the end-to-end log. - Test clients are now closed in an `@AfterEach`. - AI disclosure added to the description per the new template. @davidradl on the duplicates question: yes, if the server applied part of a batch before answering 500, the retry resends the whole batch. The sink cannot know which records were applied from a status code alone, so the docs ask for an idempotent endpoint when that matters. The CI run for the new head is waiting for workflow approval. Could one of you approve it? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
