MartijnVisser commented on code in PR #29588: URL: https://github.com/apache/flink/pull/29588#discussion_r4375279719
########## tools/ci/free_disk_space.sh: ########## @@ -52,10 +55,10 @@ echo "Removing large packages" sudo apt-get remove -y '^postgresql-.*' || true sudo apt-get remove -y '^g\+\+-.*' '^clang-.*' '^libclang-.*' || true sudo apt-get remove -y '^gfortran-.*' '^libruby.*' || true - sudo apt-get remove -y temurin-8-jdk || true - sudo apt-get remove -y '^libllvm.*' '^libclang1.*' snapd python3-botocore podman buildah skopeo mecab-ipadic gh git-lfs || true - sudo apt-get remove -y azure-cli google-cloud-sdk google-chrome-stable google-cloud-cli firefox microsoft-edge-stable powershell mono-devel libgl1-mesa-dri || true - sudo apt-get autoremove -y || true + remove_pkgs temurin-8-jdk + sudo apt-get remove -y '^libllvm.*' '^libclang1.*' || true + remove_pkgs snapd python3-botocore podman buildah skopeo mecab-ipadic gh git-lfs + remove_pkgs azure-cli google-cloud-sdk google-chrome-stable google-cloud-cli firefox microsoft-edge-stable powershell mono-devel libgl1-mesa-dri sudo apt-get autoremove -y || true Review Comment: I think a newline went missing before `sudo apt-get autoremove -y`. `sudo` is now passed to `remove_pkgs`, so both CIs log `Removing sudo` and `Removing ubuntu-minimal`, and autoremove never runs. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
