raminqaf opened a new pull request, #29610:
URL: https://github.com/apache/flink/pull/29610
## What is the purpose of the change
Backport of #29416 to release-2.4. FLINK-40910 (#29411) is already on
release-2.4, so 2.4 rejects VARIANT in GROUP BY, joins and comparisons. Without
this commit, 2.4 still accepts VARIANT elements and keys in ARRAY_CONTAINS,
MAP_CONTAINS_KEY, `m[k]`, COLLECT and the other functions that compare them,
and returns wrong results for equal VARIANT values.
## Brief change log
- Cherry-pick of 5c9455b113e, applied without conflicts
## Verifying this change
`LogicalTypeChecksTest`, `ComparableInputTypeStrategyTest`,
`ComparableTypeValidatorTest`, `CastFunctionITCase`, `MapFunctionITCase` and
`CollectionFunctionsITCase` pass on this branch.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): no
- The public API, i.e., is any changed class annotated with
`@Public(Evolving)`: no. Calls of these functions and operators with VARIANT
elements or keys now fail, see the release note on FLINK-40936.
- The serializers: no
- The runtime per-record code paths (performance sensitive): no
- Anything that affects deployment or recovery: JobManager (and its
components), Checkpointing, Kubernetes/Yarn, ZooKeeper: yes. A restored
compiled plan that calls one of the array or map functions on VARIANT elements
or keys fails when it is executed, as in #29416.
- The S3 file system connector: no
## Documentation
- Does this pull request introduce a new feature? no
- If yes, how is the feature documented? not applicable
---
##### Was generative AI tooling used to co-author this PR?
- [X] Yes (please specify the tool below)
Generated-by: Claude Code 2.1.310 (Claude Opus 5.5)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
