spuru9 commented on code in PR #220: URL: https://github.com/apache/flink-connector-jdbc/pull/220#discussion_r4377686925
########## docs/content/docs/connectors/datastream/jdbc.md: ########## @@ -93,12 +160,16 @@ remains unchanged in the whole lifecycle of `JdbcSourceSplit` processing. Unfortunately, this condition is not met in most databases and data scenarios. See [FLIP-239](https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=217386271) for more details. +Using `DeliveryGuarantee.EXACTLY_ONCE` requires `setResultSetType` to be either +`ResultSet.TYPE_SCROLL_INSENSITIVE` or `ResultSet.CONCUR_READ_ONLY`; other values fail at `build()` Review Comment: Good catch, filed [FLINK-41208](https://issues.apache.org/jira/browse/FLINK-41208) to fix the check in `JdbcSourceBuilder.build()`. Will document only `TYPE_SCROLL_INSENSITIVE` here. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
