bharathgunapati commented on PR #62: URL: https://github.com/apache/flink-connector-http/pull/62#issuecomment-6420359045
@MartijnVisser this is the fix for FLINK-41192, which you filed. An exception thrown while starting an attempt now becomes a failed stage, so Resilience4j's `retryOnException` sees it: an I/O cause is retried like a transport error, anything else fails the request through the writer's existing exception path. The three new tests in `HttpSinkClientWithRetryTest` and the one in `JavaNetSinkHttpClientTest` follow your reproduction (retryable result on the first attempt, throw on the second). They time out after 5 s on main and pass with the fix. Since #58 makes the bug reachable through the per-request token fetch, this should go in before #58. Could you approve the CI run when you get a chance? Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
