Savonitar commented on PR #133: URL: https://github.com/apache/flink-connector-pulsar/pull/133#issuecomment-6420860164
Hi @ferenc-csaky and @poorbarcode, Following [our discussion in #130](https://github.com/apache/flink-connector-pulsar/pull/130#discussion_r4346450312), I opened draft PR [#133](https://github.com/apache/flink-connector-pulsar/pull/133). The [Pulsar broker code](https://github.com/apache/pulsar/blob/v4.0.14/pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentTopic.java#L5005-L5008) confirms that deduplicated sends can succeed with ledger and entry IDs of -1. Without filtering these IDs, a duplicate-only checkpoint records -1/-1 as a persisted message position in its metadata. The PR adds the filter and a regression test against a real Pulsar broker. The test fails without the filter, with batching both enabled and disabled. Please let me know what you think. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
