raminqaf opened a new pull request, #29622:
URL: https://github.com/apache/flink/pull/29622
## What is the purpose of the change
Backport of #29607 to release-2.4. Without it, 2.4.0 writes VARIANT objects
in UTF-16 order instead of the spec's UTF-8 byte order, and `getField("😀")`
misses the field in a spec-ordered object of 32 or more fields, such as one
another engine wrote. 2.4.0 is not released yet, so taking this now avoids
changing the field order in a 2.4.x patch release.
## Brief change log
- Cherry-picks of the three #29607 commits, applied without conflicts:
- 82834bb220b [FLINK-41110][core] Compare UTF-8 bytes to find VARIANT
object fields
- e9939d53403 [hotfix][docs] Sync the zh VARIANT data type docs with en
- dab40d31eba [FLINK-41180][core] Sort VARIANT object fields by UTF-8
bytes
## Verifying this change
`BinaryVariantTest`, `BinaryVariantInternalBuilderTest`,
`JsonVariantFormatterTest`, `FromVariantConverterTest`,
`ToVariantConverterTest`, `VariantCastUtilsTest` and `XmlToVariantParserTest`
pass on this branch, 428 tests.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): no
- The public API, i.e., is any changed class annotated with
`@Public(Evolving)`: yes, behavior only. `BinaryVariantBuilder` treats keys
with the same UTF-8 bytes as duplicates. No signature changes.
- The serializers: no
- The runtime per-record code paths (performance sensitive): yes,
`getField` and object building.
- Anything that affects deployment or recovery: JobManager (and its
components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
- The S3 file system connector: no
## Documentation
- Does this pull request introduce a new feature? no
- If yes, how is the feature documented? not applicable. The en and zh
`data-types.md` now name the key order.
---
##### Was generative AI tooling used to co-author this PR?
- [X] Yes (please specify the tool below)
Generated-by: Claude Code 2.1.310 (Claude Opus 5.5)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
