hanyuzheng7 commented on code in PR #29624: URL: https://github.com/apache/flink/pull/29624#discussion_r4390933375
########## flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/operators/values/ValuesGeneratorFunction.java: ########## @@ -0,0 +1,70 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.table.runtime.operators.values; + +import org.apache.flink.annotation.Internal; +import org.apache.flink.api.common.io.GenericInputFormat; +import org.apache.flink.api.connector.source.SourceReaderContext; +import org.apache.flink.connector.datagen.source.GeneratorFunction; +import org.apache.flink.table.data.RowData; +import org.apache.flink.table.runtime.generated.GeneratedInput; +import org.apache.flink.table.runtime.typeutils.InternalTypeInfo; +import org.apache.flink.table.runtime.typeutils.RowDataSerializer; + +import java.util.ArrayList; +import java.util.List; + +/** + * Returns the row of a {@code VALUES} clause for a row number. The generated format only reads + * forward, so {@link #open} reads all rows once. + */ +@Internal +public class ValuesGeneratorFunction implements GeneratorFunction<Long, RowData> { + + private static final long serialVersionUID = 1L; + + private final GeneratedInput<GenericInputFormat<RowData>> generatedInput; + private final InternalTypeInfo<RowData> producedType; + + private transient List<RowData> rows; + + public ValuesGeneratorFunction( + GeneratedInput<GenericInputFormat<RowData>> generatedInput, + InternalTypeInfo<RowData> producedType) { + this.generatedInput = generatedInput; + this.producedType = producedType; + } + + @Override + public void open(SourceReaderContext readerContext) throws Exception { + final GenericInputFormat<RowData> format = + generatedInput.newInstance(readerContext.getUserCodeClassLoader().asClassLoader()); + // The generated format returns the same row object each time. + final RowDataSerializer serializer = producedType.toRowSerializer(); + rows = new ArrayList<>(); + while (!format.reachedEnd()) { + rows.add(serializer.copy(format.nextRecord(null))); + } Review Comment: Thanks, I agree. The generated `nextRecord` already picks the row by index `(if (nextIdx == i))`, so the `InputFormat` only adds a layer here. I'll generate a `GeneratorFunction `directly, whose `map(index)` builds the row for that index. Then we don't need to iterate an `InputFormat` or keep a copy of all rows, and the memory is the same as with the legacy source. The legacy path (version 1, batch and VALUES without rows) will still use the generated InputFormat. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
