[
https://issues.apache.org/jira/browse/FLINK-5695?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15855575#comment-15855575
]
Fabian Hueske commented on FLINK-5695:
--------------------------------------
Hi [~sunjincheng121],
IDEs usually show the Java / ScalaDocs of methods when browsing the available
methods of an object.
If there are two {{select}} methods, each method can have it's own ScalaDoc:
The docs of {{GroupWindowedTable.select()}} can explain how to compute windowed
aggregates (how to use window().groupBy().select()) and how to access window
properties. The docs {{GroupedTable.select()}} can be targeted towards the
non-windowed case.
>From an internal design point of view I like the separation into two classes
>more because the translation logic of the windowed and non-windowed case does
>not have a lot in common. That could of course also be addressed by splitting
>the translation logic into two private methods in {{GroupedTable}} but then we
>would lose the targeted documentation.
Best, Fabian
> Optimize table type systems based on database semantics
> -------------------------------------------------------
>
> Key: FLINK-5695
> URL: https://issues.apache.org/jira/browse/FLINK-5695
> Project: Flink
> Issue Type: Sub-task
> Components: Table API & SQL
> Reporter: sunjincheng
> Assignee: sunjincheng
>
> Optimize table type systems based on database semantics.As follows:
> {code}
> groupBy
> -------------------->
> Table GroupedTable
> ∧ <-------------------- ∧
> | select&agg |
> | |
> | where |
> | select | groupBy
> | agg |
> | ... |
> | window |
> ∨ --------------------->
> Table WindowedTable
> <---------------------
> select&over
> {code}
> What do you think? [~fhueske]
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
