raminqaf commented on code in PR #29636:
URL: https://github.com/apache/flink/pull/29636#discussion_r4394227883


##########
flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/planner/codegen/calls/ScalarOperatorGens.scala:
##########
@@ -1748,10 +1748,12 @@ object ScalarOperatorGens {
       )
     } else if (isCharacterString(keyType)) {
       val fieldName = key.literalValue.get.toString

Review Comment:
   Yes this was a bug on master. The validator accepts a non-literal key, but 
codegen didn't: `SELECT v[k] FROM t` with a STRING column k failed on master 
with `NoSuchElementException`. Same for Table API. I have created FLINK-41243 
and added the fix as the first commit of this PR. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to