[
https://issues.apache.org/jira/browse/FLINK-5727?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15855583#comment-15855583
]
ASF GitHub Bot commented on FLINK-5727:
---------------------------------------
Github user fhueske commented on the issue:
https://github.com/apache/flink/pull/3281
Hi @KurtYoung,
thanks for the refactoring. Moving `sql()` and `scan()` to
`TableEnvironment` makes sense.
However, I'd like to keep `registerTableSource` at the
`BatchTableEnvironment` and `StreamTableEnvironment` because this separation
ensures that a `BatchTableSource` is not registered at a
`StreamTableEnvironment` and vice versa.
What do you think?
Best, Fabian
> Unify some API of batch and stream TableEnvironment
> ---------------------------------------------------
>
> Key: FLINK-5727
> URL: https://issues.apache.org/jira/browse/FLINK-5727
> Project: Flink
> Issue Type: Improvement
> Components: Table API & SQL
> Reporter: Kurt Young
> Assignee: Kurt Young
>
> Some API's implementation of current {{BatchTableEnvironment}} and
> {{StreamTableEnvironment}} is identical, like {{sql}}. And other API like
> {{registerTableSource}} and {{scan}} can be unified to the base class. (we
> can change {{ingest}} from {{StreamTableEnvironment}} to {{scan}} also)
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
