dianfu commented on PR #29640:
URL: https://github.com/apache/flink/pull/29640#issuecomment-6464611461
@snuyanzin Thanks for this work!
just one comment: with parallel execution, the gateway JVMs started by
different workers currently will write to the same log file
`flink-${user}-python-${hostname}.log`. They can truncate and overwrite each
other’s logs. This can lose useful diagnostics of testing cases.
Could we use pytest’s pytest_configure initialization hook in conftest.py to
isolate the logs? This hook runs in each worker before test collection. We
could identify the worker through PYTEST_XDIST_WORKER, create a unique
subdirectory under the existing log directory, and set that worker’s
FLINK_LOG_DIR accordingly. The gateway JVM would inherit this environment
variable, and the logging test would read the same directory, preserving its
single-log-file assertion.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
