laughingman7743 commented on PR #1221: URL: https://github.com/apache/flink-kubernetes-operator/pull/1221#issuecomment-6469891358
Thank you for the review and the suggestion, @Dennis-Mircea. That makes sense, and it is simpler as well. I have reworked the PR to add `@JsonIgnoreProperties(ignoreUnknown = true)` to `ClusterHealthInfo` instead of mapping the legacy field. I also checked how the legacy info is handled with this change: `healthResult` keeps the default `ClusterHealthResult.healthy()` from the constructor, so it is never `null`, and `ClusterHealthEvaluator` replaces it with a new verdict on the next observation. I added an evaluator test with legacy health info stored in `clusterInfo`, and updated the PR title and description accordingly. Could you please take another look when you have time? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
