bharathgunapati commented on PR #32: URL: https://github.com/apache/flink-connector-http/pull/32#issuecomment-6470475370
Hi @featzhang, thanks for this. Looking at it again against main, both factories already accept the header prefixes through `validateExcept`, so the new Map options don't change validation or runtime behaviour, and having the headers documented in two places could confuse users. The part that is still valuable is your correction of `http-sink` to `http-async-sink` in the DataStream docs and the Javadoc, which is still wrong on main today. Would you be fine with closing this PR and landing that fix on its own? How headers are declared as options can then be settled in FLINK-40702. Thanks again for catching the identifier. cc: @davidradl -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
