bharathgunapati commented on PR #33:
URL: 
https://github.com/apache/flink-connector-http/pull/33#issuecomment-6470528258

   Hi @featzhang, thanks for the work on this, and sorry it sat for so long. In 
the meantime sink retries landed in #54 (FLINK-40277), and they ended up with 
the same option names you converged on here (`http.sink.max-retries`, 
`retry-codes`, `success-codes`, `retry-strategy.*`), implemented in the client 
with Resilience4j. With that merged I don't think there is anything left for 
this PR to add, so unless you see something we missed, I'd propose closing it 
and resolving FLINK-39366 as a duplicate of FLINK-40277. Further retry work is 
tracked under FLINK-40275 if you'd like to pick any of it up.
   cc: @davidradl 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to