sd4324530 commented on code in PR #4362:
URL: https://github.com/apache/flink-cdc/pull/4362#discussion_r4402045192
##########
flink-cdc-connect/flink-cdc-source-connectors/flink-cdc-base/src/main/java/org/apache/flink/cdc/connectors/base/options/JdbcSourceOptions.java:
##########
@@ -110,4 +110,11 @@ public class JdbcSourceOptions extends SourceOptions {
.withDescription(
"The chunk key of table snapshot, captured tables
are split into multiple chunks by a chunk key when read the snapshot of table."
+ "By default, the chunk key is the first
column of the primary key and the chunk key is the RowId in oracle.");
+
+ public static final ConfigOption<Double> RECORDS_PER_SECOND =
+ ConfigOptions.key("records.per.second")
Review Comment:
I agree to rename it to `scan.rate-limit.records-per-second`, which is
indeed more unified and clear, and it's done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
