mateczagany commented on code in PR #29484:
URL: https://github.com/apache/flink/pull/29484#discussion_r4402476634
##########
flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/planner/plan/nodes/physical/common/CommonPhysicalJoin.scala:
##########
@@ -88,10 +88,6 @@ abstract class CommonPhysicalJoin(
val upsertKeys = FlinkRelMetadataQuery
.reuseOrCreate(cluster.getMetadataQuery)
.getUpsertKeysInKeyGroupRange(input, keys)
- if (upsertKeys == null || upsertKeys.isEmpty) {
- List.empty
- } else {
- upsertKeys.map(_.asList.map(_.intValue).toArray).toList
- }
+ UpsertKeyUtil.sortedKeys(upsertKeys).toList
Review Comment:
I don't think I like the comment, the order of the keys in the plan is
already documented in the javadoc of `UpsertKeyUtil#sortedKeys`.
If you want, I can add a unit-test instead that pins this behavior.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
