andrew-stein-sp opened a new pull request, #29642:
URL: https://github.com/apache/flink/pull/29642
## What is the purpose of the change
Fixes FLINK-41249. The `JoinKeyContainsUniqueKey` async state views hand the
same list to every lookup, so on ForSt another key's lookup can overwrite it
before the join reads it. Each lookup now gets its own list, like the other
views.
## Brief change log
- Allocate the result list per lookup in both `JoinKeyContainsUniqueKey`
views
- Add a harness test that runs the join on ForSt (adds
`flink-statebackend-forst` as a test dependency)
## Verifying this change
`AsyncStateStreamingJoinOperatorForStTest`: without the fix, 999 of 1,000
joined rows pair different keys; with it, all match. The existing harness tests
run on heap state, where async requests complete synchronously, so they never
hit this.
## Does this pull request potentially affect one of the following parts:
- Dependencies: test-scoped `flink-statebackend-forst` only
- The public API: no
- The serializers: no
- The runtime per-record code paths: one small list allocation per lookup
- Deployment or recovery: no
- The S3 file system connector: no
## Documentation
- New feature: no
---
##### Was generative AI tooling used to co-author this PR?
- [X] Yes (please specify the tool below)
Generated-by: Cursor (Claude Opus 5.5)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
