Copilot commented on code in PR #29564:
URL: https://github.com/apache/flink/pull/29564#discussion_r4410370075
##########
flink-core/src/main/java/org/apache/flink/configuration/MetricOptions.java:
##########
@@ -391,6 +391,31 @@ public static Configuration forReporter(Configuration
configuration, String repo
+ "The range of the priority is from 1
(MIN_PRIORITY) to 10 (MAX_PRIORITY). "
+ "Warning, increasing this value may
bring the main Flink components down.");
+ /**
+ * Metrics matching one of these filters are not exposed through Flink's
internal metric query
+ * service and therefore neither through the REST API nor the web UI. They
are still reported to
+ * configured metric reporters.
+ */
+ public static final ConfigOption<List<String>> QUERY_SERVICE_EXCLUDES =
+ key("metrics.internal.query-service.filter.excludes")
+ .stringType()
+ .asList()
+ .defaultValues("*.operator.split.watermark:*:*")
Review Comment:
The default filter also hides unrelated custom groups such as
`taskmanager.job.task.operator.split_watermark`, removing their metrics from
REST/UI without explicit configuration.
`DefaultReporterFilters.convertToPattern()` leaves dots unescaped in the
regular expression, so `split.watermark` also matches `split_watermark`. Make
scope separators match literally while preserving wildcard and
configured-delimiter support, and add a regression test that keeps similarly
named custom groups visible.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
