polyzos commented on PR #29653: URL: https://github.com/apache/flink/pull/29653#issuecomment-6494245259
Thanks @fresh-borzoni for picking 👍 — the equivalence logic and plan-test coverage here are good. 👍 **areUpsertKeysDifferentFromPk** (used for the DELETE_BY_KEY delete-trait decision) still goes through raw fmq.getUpsertKeys with exact equality against the sink PK, rather than UpsertKeyEquivalenceUtil. So even in the PR's own motivating example, the sink may still fall back to full before/after delete instead of DELETE_BY_KEY. Was that left out on purpose, or worth folding in here too? Nice work overall! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
