sqd opened a new pull request, #344:
URL: https://github.com/apache/flink-connector-kafka/pull/344

   ## What is the purpose of the change
   
   Since [FLINK-39888](https://issues.apache.org/jira/browse/FLINK-39888) an 
explicit auto.offset.reset takes precedence over the
   starting offsets initializer's strategy. For committedOffsets(), splits
   start at COMMITTED_OFFSET and the consumer applies auto.offset.reset to
   partitions without a committed offset, so the property also decides where
   those partitions start. The builder warning misleadingly said the 
initializer is used
   for startup, and the docs and Javadoc implied the same.
   
   Reword the warning, the committedOffsets() Javadoc and the DataStream
   docs to describe the actual behavior.
   
   
   ## Brief change log
   
   - Reworded the auto.offset.reset mismatch warning in `KafkaSourceBuilder` and
     `DynamicKafkaSourceBuilder`: it no longer claims the initializer is used 
for
     startup, and now notes that with committed offsets the explicit property
     also decides where partitions without a committed offset start.
   - Updated the `OffsetsInitializer.committedOffsets()` and
     `committedOffsets(OffsetResetStrategy)` Javadoc to say an explicit
     auto.offset.reset takes precedence.
   - Added the same note to the DataStream Kafka docs (English and Chinese).
   
   ## Verifying this change
   
   This change is a trivial rework / code cleanup without any test coverage.
   
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency, including 
`kafka.version` or `flink.version`): no
     - The public API, i.e., is any changed class annotated with 
`@Public(Evolving)` or `@Experimental`, or are the Table options or the PyFlink 
wrappers changed: no
     - Checkpointed state, its serializers, or exactly-once delivery (splits, 
enumerator state, writer state, committables, transactions): no
     - The per-record code paths (split reader, record emitter, writer, 
serialization schemas; performance sensitive): no
   
   ## Documentation
   
     - Does this pull request introduce a new feature? no
     - If yes, how is the feature documented? docs / JavaDocs
     - If the docs changed, are both `docs/content` and `docs/content.zh` 
updated? yes
   
   ---
   
   ##### Was generative AI tooling used to co-author this PR?
   
   - [x] Yes (please specify the tool below)
   
   Generated-by: Claude Opus 5.5 (Claude Code)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to