gustavodemorais commented on code in PR #29661:
URL: https://github.com/apache/flink/pull/29661#discussion_r4414773173
##########
flink-python/pyflink/table/tests/test_table_environment_api.py:
##########
@@ -460,6 +460,18 @@ def test_use_nonexistent_module(self):
Py4JJavaError, "No module with name 'dummy' exists",
self.t_env.use_modules, 'core', 'dummy')
+ def test_list_materialized_tables_in_given_namespace(self):
+ self.t_env.execute_sql(
+ "CREATE CATALOG other_catalog WITH ("
+ "'type' = 'generic_in_memory', 'default-database' =
'other_database')")
+
+ self.assertEqual(
+ [], self.t_env.list_materialized_tables('other_catalog',
'other_database'))
Review Comment:
nit (optional): a no-arg call would also cover the existing path.
```suggestion
[], self.t_env.list_materialized_tables('other_catalog',
'other_database'))
self.assertEqual([], self.t_env.list_materialized_tables())
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
