[
https://issues.apache.org/jira/browse/FLINK-5153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15855753#comment-15855753
]
ASF GitHub Bot commented on FLINK-5153:
---------------------------------------
Github user rmetzger commented on the issue:
https://github.com/apache/flink/pull/3268
Hi Patrick,
the change looks good in general (you updated the documentation as well :)
).
One thing I'm missing a bit from the change is a test case.
We have an entire package (which is, admittedly pretty ugly) for YARN tests.
Maybe you can just pass your new config option to one of the existing tests
and then check if the tag has been set.
> Allow setting custom application tags for Flink on YARN
> -------------------------------------------------------
>
> Key: FLINK-5153
> URL: https://issues.apache.org/jira/browse/FLINK-5153
> Project: Flink
> Issue Type: Improvement
> Components: YARN
> Reporter: Robert Metzger
> Assignee: Patrick Lucas
>
> https://issues.apache.org/jira/browse/YARN-1399 added support in YARN to tag
> applications.
> We should introduce a configuration variable in Flink allowing users to
> specify a comma-separated list of tags they want to assign to their Flink on
> YARN applications.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
