wenjin272 commented on PR #1172: URL: https://github.com/apache/flink-agents/pull/1172#issuecomment-6518756245
Sorry for the delayed review—I’ve been focused on the 0.4 release work. Thanks for your patience and for working on this! We explored the alternative of setting `execution.batch-state-backend.enabled=false`. BATCH jobs can still use keyed state with a regular state backend, allowing Agents to retain cross-key concurrency. For these workloads, disabling `execution.sorted-inputs.enabled` as well would avoid unnecessary input-sorting overhead, provided other operators don’t require it. However, both settings apply job-wide and default to `true`. Supporting that default configuration correctly is valuable, so I think the approach in this PR is reasonable. Users who need cross-key concurrency can still disable the batch-specific backend. It would be helpful to document this tradeoff and retain regression coverage for the disabled-backend configuration alongside the new default-backend tests. WDYT? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
