eskabetxe commented on code in PR #29422:
URL: https://github.com/apache/flink/pull/29422#discussion_r4422721681


##########
flink-filesystems/flink-s3-fs-base/src/main/java/org/apache/flink/fs/s3/common/writer/S3RecoverableSerializer.java:
##########
@@ -41,6 +41,9 @@ final class S3RecoverableSerializer implements 
SimpleVersionedSerializer<S3Recov
 
     private static final int MAGIC_NUMBER = 0x98761432;
 
+    // One-time copy: flink-s3-fs-native duplicates this decoder (FLINK-40943).
+    // Later format changes are not mirrored there.
+

Review Comment:
   Initially to give a relation with the copy and if something change we change 
on the native copy.
   With @gaborgsomogyi we decide it will be only one time copy, with that makes 
sense to remove..
   
   @gaborgsomogyi are you ok with it?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to