[
https://issues.apache.org/jira/browse/FLINK-5702?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15855918#comment-15855918
]
ASF GitHub Bot commented on FLINK-5702:
---------------------------------------
Github user tzulitai commented on the issue:
https://github.com/apache/flink/pull/3282
The comments have been addressed. Apart from the minor fixes for grammar,
all sections were moved up the hierarchy by one to show a better ToC. The
at-least-once info for the producer is moved to a sub-section called "Kafka
Producers and Fault Tolerance" (coherent with the naming for exactly-once info
on the consumer side).
> Kafka Producer docs should warn if using setLogFailuresOnly, at-least-once is
> compromised
> -----------------------------------------------------------------------------------------
>
> Key: FLINK-5702
> URL: https://issues.apache.org/jira/browse/FLINK-5702
> Project: Flink
> Issue Type: Improvement
> Components: Documentation, Kafka Connector
> Reporter: Tzu-Li (Gordon) Tai
> Assignee: Tzu-Li (Gordon) Tai
>
> The documentation for FlinkKafkaProducer does not have any information about
> the {{setLogFailuresOnly}}. It should emphasize that if users choose to only
> log failures instead of failing the sink, at-least-once can not be guaranteed
> .
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)