fresh-borzoni commented on code in PR #29653: URL: https://github.com/apache/flink/pull/29653#discussion_r4424443016
########## flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/metadata/FlinkRelMdEquiJoinColumnPairs.java: ########## @@ -0,0 +1,180 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.table.planner.plan.metadata; + +import org.apache.flink.table.planner.plan.nodes.physical.stream.StreamPhysicalMultiJoin; + +import org.apache.calcite.plan.RelOptUtil; +import org.apache.calcite.plan.hep.HepRelVertex; +import org.apache.calcite.plan.volcano.RelSubset; +import org.apache.calcite.rel.RelNode; +import org.apache.calcite.rel.core.Calc; +import org.apache.calcite.rel.core.Exchange; +import org.apache.calcite.rel.core.Join; +import org.apache.calcite.rel.core.JoinRelType; +import org.apache.calcite.rel.core.Project; +import org.apache.calcite.rel.metadata.MetadataDef; +import org.apache.calcite.rel.metadata.MetadataHandler; +import org.apache.calcite.rel.metadata.ReflectiveRelMetadataProvider; +import org.apache.calcite.rel.metadata.RelMetadataProvider; +import org.apache.calcite.rel.metadata.RelMetadataQuery; +import org.apache.calcite.rex.RexCall; +import org.apache.calcite.rex.RexInputRef; +import org.apache.calcite.rex.RexNode; +import org.apache.calcite.sql.SqlKind; +import org.apache.calcite.util.Util; +import org.apache.calcite.util.mapping.IntPair; + +import java.util.ArrayList; +import java.util.HashMap; +import java.util.List; +import java.util.Map; +import java.util.stream.Collectors; + +/** A metadata handler for {@link FlinkMetadata.EquiJoinColumnPairs}. */ +public class FlinkRelMdEquiJoinColumnPairs + implements MetadataHandler<FlinkMetadata.EquiJoinColumnPairs> { + static final FlinkRelMdEquiJoinColumnPairs INSTANCE = new FlinkRelMdEquiJoinColumnPairs(); + + public static final RelMetadataProvider SOURCE = + ReflectiveRelMetadataProvider.reflectiveSource( + FlinkMetadata.EquiJoinColumnPairs.METHOD, INSTANCE); + + // ~ Constructors ----------------------------------------------------------- + + private FlinkRelMdEquiJoinColumnPairs() {} + + // ~ Methods ---------------------------------------------------------------- + + public MetadataDef<FlinkMetadata.EquiJoinColumnPairs> getDef() { + return FlinkMetadata.EquiJoinColumnPairs.DEF; + } + + public List<EquiJoinColumnPair> getEquiJoinColumnPairs(Join join, RelMetadataQuery mq) { Review Comment: All four extend Join. The pairs only assume every emitted row satisfies the equi condition, with padded sides marked, which holds for all of them, including an EARLY_FIRE outer interval join. Window and interval joins pass their remaining condition, so at worst they get fewer pairs. The uniqueness check is the same rule FlinkRelMdUpsertKeys uses for them. Temporal join forwards updates, so I added inner and left temporal join tests. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
