laughingman7743 commented on code in PR #28498:
URL: https://github.com/apache/flink/pull/28498#discussion_r4431580174
##########
flink-formats/flink-avro-confluent-registry/src/main/java/org/apache/flink/formats/avro/registry/confluent/debezium/DebeziumAvroDeserializationSchema.java:
##########
@@ -133,30 +262,48 @@ public void deserialize(byte[] message,
Collector<RowData> out) throws IOExcepti
return;
}
try {
+ // Initialize generic deserializer with the first record's runtime
writer schema
Review Comment:
Thanks for the quick turnaround. I checked dd0dbea on top of master
(29a37c6e). The existing and new tests in `DebeziumAvroSerDeSchemaTest` and
`DebeziumAvroFormatFactoryTest` pass, and so does my reproduction: a
PostgreSQL-shaped envelope requesting only `source.properties` returns `lsn`,
`sequence` and `txId`, and both schema-evolution cases now read as written.
With the previous `DebeziumAvroDeserializationSchema` restored, your two new
tests fail as expected. Initializing the coder and the reader cache in `open()`
is fine. This looks good to me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
