Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/3266#discussion_r99996840
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/AggregateUtil.scala
---
@@ -291,13 +292,13 @@ object AggregateUtil {
inputType,
Option(Array(BasicTypeInfo.LONG_TYPE_INFO,
BasicTypeInfo.LONG_TYPE_INFO)))
- new DataSetSessionWindowAggregateCombineGroupFunction(
+ new DataSetSessionWindowAggregatePreProcessor(
aggregates,
groupings,
// the addition two fields are used to store window-start and
window-end attributes
intermediateRowArity + 2,
asLong(gap),
- combineReturnType)
+ combineReturnType).asInstanceOf[GroupCombineFunction[Row,Row]]
--- End diff --
Can we leave out the `asInstanceOf` ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
