spuru9 opened a new pull request, #29715:
URL: https://github.com/apache/flink/pull/29715
## What is the purpose of the change
`GET /applications/<id>` and `GET /applications/<id>/exceptions` return HTTP
500 "Internal server error." for an unknown or expired application, because
`FlinkApplicationNotFoundException` is passed through unmapped. This makes them
return 404, as the job handlers and `ApplicationCancellationHandler` already do.
## Brief change log
- `ApplicationDetailsHandler` and `ApplicationExceptionsHandler` map
`FlinkApplicationNotFoundException` to `NotFoundException` (404).
## Verifying this change
This change added tests and can be verified as follows:
- Added `testUnknownApplicationRespondsWithNotFound` to
`ApplicationDetailsHandlerTest` and `ApplicationExceptionsHandlerTest`; both
fail without the fix.
- Manually verified on a Flink 2.3.0 session cluster on minikube
(`jobstore.expiration-time: 60`) with the fixed `ApplicationDetailsHandler`:
once the application expired, `GET /applications/<id>` went from 200 to 404
(`Application <id> not found`) instead of 500, and the JobManager stopped
logging `ApplicationDetailsHandler - Unhandled exception.`
Before, the dashboard's Application page polling an expired application:
_(drop screenshot: before-application-page.png)_
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): no
- The public API, i.e., is any changed class annotated with
`@Public(Evolving)`: no
- The serializers: no
- The runtime per-record code paths (performance sensitive): no
- Anything that affects deployment or recovery: JobManager (and its
components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
- The S3 file system connector: no
## Documentation
- Does this pull request introduce a new feature? no
- If yes, how is the feature documented? not applicable
---
##### Was generative AI tooling used to co-author this PR?
- [X] Yes (please specify the tool below)
Generated-by: Claude Opus 5.5
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
