raminqaf opened a new pull request, #29726:
URL: https://github.com/apache/flink/pull/29726
## What is the purpose of the change
Backport of #29689 to release-2.4. `CAST` of a `TIMESTAMP` before 1970 to
`DATE`, to `TIME` or to a lower precision returns a wrong value on release-2.4
too. With `f0 = TIMESTAMP(3) '1969-12-31 23:59:59.999'` as a column:
| Query | Before | After
|
|------------------------------|-----------------------|-----------------------|
| `CAST(f0 AS DATE)` | `1970-01-01` | `1969-12-31`
|
| `CAST(f0 AS TIME(0))` | `00:00` | `23:59:59`
|
| `CAST(f0 AS TIMESTAMP(0))` | `1970-01-01T00:00` |
`1969-12-31T23:59:59` |
## Brief change log
- Cherry-pick of 01966740401, applied without conflicts
## Verifying this change
`CastFunctionITCase` (1097 tests, including the three new cases) and
`CastRulesTest` (806 tests) pass on this branch.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): no
- The public API, i.e., is any changed class annotated with
`@Public(Evolving)`: no
- The serializers: no
- The runtime per-record code paths (performance sensitive): yes, the cast
itself, as in #29689. `Math.floorDiv` and `Math.floorMod` only add a sign check.
- Anything that affects deployment or recovery: JobManager (and its
components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
- The S3 file system connector: no
## Documentation
- Does this pull request introduce a new feature? no
- If yes, how is the feature documented? not applicable
---
##### Was generative AI tooling used to co-author this PR?
- [X] Yes (please specify the tool below)
Generated-by: Claude Code 2.1.316 (Claude Opus 5.5)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
