hanyuzheng7 commented on code in PR #29723:
URL: https://github.com/apache/flink/pull/29723#discussion_r4446555529
##########
flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/runtime/utils/JoinReorderITCaseBase.java:
##########
@@ -377,6 +377,23 @@ public void testBushyTreeJoinReorder(boolean
isBushyJoinReorder)
assertEquals(query, expectedList);
}
+ @ParameterizedTest(name = "Is bushy join reorder: {0}")
+ @ValueSource(booleans = {true, false})
+ public void testJoinReorderWithFilterOnNullGeneratingSideOfLeftOuterJoin(
Review Comment:
Replaced the IT with the semantic test program
`JoinReorderSemanticTestPrograms.FILTER_ON_NULL_GENERATING_SIDE_OF_LEFT_JOIN`,
run in streaming (`JoinReorderSemanticTests`) and batch mode
(`JoinReorderBatchSemanticTests`). Without the fix, both fail: the row of t1
without a match is missing.
Or you think we can add these semantic tests in a exist class?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
