Dennis-Mircea opened a new pull request, #1243:
URL: https://github.com/apache/flink-kubernetes-operator/pull/1243
## What is the purpose of the change
This PR limits canary resources to `FlinkDeployment`, deprecates
`FlinkSessionJob` canaries, and makes the operator and the validation webhook
handle canary-labelled resources of the other kinds explicitly.
## Brief change log
- `FlinkStateSnapshotController` and `FlinkBlueGreenDeploymentController`
skip the reconciliation of canary-labelled resources and log a warning that
canaries must be `FlinkDeployment` resources.
- `FlinkSessionJobController` keeps handling `FlinkSessionJob` canaries and
logs a deprecation warning once, on the first canary reconciliation.
- `FlinkValidator` only skips the validation of `FlinkDeployment` and
`FlinkSessionJob` canaries. A `FlinkStateSnapshot` is rejected when the canary
label is added (on creation, or on an update adding the label). Updates of
snapshots that already have the label are still accepted, so their finalizer
can be removed on deletion.
- The health documentation recommends a single `FlinkDeployment` canary, as
all resource kinds in all watched namespaces share the same reconciliation
thread pool, and marks `FlinkSessionJob` canaries as deprecated.
## Verifying this change
This change can be verified by the newly added tests and manually within
minikube on `examples/canary.yaml`.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): no
- The public API, i.e., is any changes to the `CustomResourceDescriptors`:
no
- Core observer or reconciler logic that is regularly executed: yes
## Documentation
- Does this pull request introduce a new feature? no
- If yes, how is the feature documented? not applicable
---
##### Was generative AI tooling used to co-author this PR?
<!--
If generative AI tooling has been used in the process of authoring this PR,
please
change the checkbox below to `[X]` followed by the name of the tool, and
uncomment the
"Generated-by" line. See the ASF Generative Tooling Guidance for details:
https://www.apache.org/legal/generative-tooling.html
You are responsible for the quality and correctness of every change in this
PR
regardless of the tooling used. Low-effort AI-generated PRs will be closed.
See
AGENTS.md for the full guidance.
-->
- [ ] Yes (please specify the tool below)
<!--
Generated-by: [Tool Name and Version]
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
