Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/3151#discussion_r100034748
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/taskexecutor/TaskManagerRunner.java
---
@@ -112,6 +114,13 @@ public TaskManagerRunner(
// Initialize the TM metrics
TaskExecutorMetricsInitializer.instantiateStatusMetrics(taskManagerMetricGroup,
taskManagerServices.getNetworkEnvironment());
+ HeartbeatManagerImpl heartbeatManager = new
HeartbeatManagerImpl(
+
taskManagerConfiguration.getTimeout().toMilliseconds(),
+ resourceID,
+ executor,
+ Executors.newSingleThreadScheduledExecutor(),
--- End diff --
Maybe we could add to the `RpcService` that it provides a
`ScheduledExecutorService`. If we see that the load on this executor is too
much, then we can introduce a dedicated service. What do you think?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
