Dennis-Mircea opened a new pull request, #1241:
URL: https://github.com/apache/flink-kubernetes-operator/pull/1241
## What is the purpose of the change
This PR keeps a single health check loop per canary resource (within the
same namespace with the same name), so that a dropped or replaced canary state
no longer leaves its scheduled check running.
## Brief change log
- The canary state keeps the `ScheduledFuture` of its next check, which is
cancelled wherever the state is dropped (deletion cleanup, reconcile without
the canary label, namespace no longer watched).
- The scheduled check carries the state it was created for and stops when
the manager tracks a different state for the canary.
- Reconciling a canary whose UID differs from the tracked one (recreated
without the deletion cleanup) starts a new state and cancels the old check,
instead of comparing the new canary against the old canary's generation.
## Verifying this change
The new change can be verified by the newly added test and manually within
minikube following the steps described in the JIRA ticket.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): no
- The public API, i.e., is any changes to the `CustomResourceDescriptors`:
no
- Core observer or reconciler logic that is regularly executed: no
## Documentation
- Does this pull request introduce a new feature? no
- If yes, how is the feature documented? not applicable
---
##### Was generative AI tooling used to co-author this PR?
<!--
If generative AI tooling has been used in the process of authoring this PR,
please
change the checkbox below to `[X]` followed by the name of the tool, and
uncomment the
"Generated-by" line. See the ASF Generative Tooling Guidance for details:
https://www.apache.org/legal/generative-tooling.html
You are responsible for the quality and correctness of every change in this
PR
regardless of the tooling used. Low-effort AI-generated PRs will be closed.
See
AGENTS.md for the full guidance.
-->
- [ ] Yes (please specify the tool below)
<!--
Generated-by: [Tool Name and Version]
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
