leosanqing opened a new pull request, #29764:
URL: https://github.com/apache/flink/pull/29764
## What is the purpose of the change
Fix the bug when send too long query parameter cause the bad request error.
Submitting a job from the Web UI fails with `Unable to load requested file
/bad-request.` when the program arguments are long. `JarService#runJob` sends
the parameters in the JSON body and repeats them as query parameters, and the
repeated copy pushes the request line over the REST server's 4096 byte limit.
The query parameters were added in FLINK-9499 so that the UI also worked
with the legacy handlers, which ignored the JSON body. Those handlers were
removed in FLINK-10551, and `JarRunHandler` prefers the body, so the UI no
longer needs them.
This targets `release-1.20`. Master needs a different fix because
`programArgs` was removed there, see FLINK-39310.
## Brief change log
Remove the parameter in query url, just send job submission parameters in
the request body
## Verifying this change
The web dashboard has no test framework, so this change has no automated
test coverage. `npm run ci-check` passes.
Manually verified in a browser with the dashboard built from this branch
against a Flink 1.20.3 cluster
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (no)
- The public API, i.e., is any changed class annotated with
`@Public(Evolving)`: (no)
- The serializers: (no)
- The runtime per-record code paths (performance sensitive): (no)
- Anything that affects deployment or recovery: JobManager (and its
components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (no)
- The S3 file system connector: (no)
## Documentation
- Does this pull request introduce a new feature? (no)
- If yes, how is the feature documented? (not applicable)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
