dev-donghwan commented on PR #4610: URL: https://github.com/apache/flink-cdc/pull/4610#issuecomment-6601902940
@lvyanquan Thanks for the review, that makes sense. Applied in 5d866a676: `REPLACE` now has its own branch in both serializers, and the `UPDATE` path is unchanged from master, so an `UPDATE` without a before image still fails loudly. Two small adjustments to the suggested code: - `CanalJsonSerializationSchema` on master builds the message via `reuseGenericRowData` rather than a Jackson `ObjectNode`, so the `REPLACE` case sets fields 0/1/2 (`old` = null, `data` = after, `type` = UPDATE) in the same way as the other cases. - `convertReplaceEventToRowData` also sets the `source` field. The row data is reused across events, so without it the previous event's `source` would be emitted. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
