snuyanzin commented on code in PR #29493:
URL: https://github.com/apache/flink/pull/29493#discussion_r4459790817
##########
flink-table/flink-table-common/src/main/java/org/apache/flink/table/types/inference/strategies/SpecificInputTypeStrategies.java:
##########
@@ -84,7 +84,7 @@ public static InputTypeStrategy windowTimeIndicator() {
or(
logical(LogicalTypeFamily.CHARACTER_STRING),
logical(LogicalTypeFamily.BINARY_STRING),
- logical(LogicalTypeFamily.TIMESTAMP),
+ logical(LogicalTypeFamily.DATETIME),
Review Comment:
why do you broaden `JSON_ARGUMENT` and add test only for json scalar?
what about ` JSON_OBJECTAGG`/`JSON_ARRAYAGG`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
