vsantwana commented on PR #1236: URL: https://github.com/apache/flink-kubernetes-operator/pull/1236#issuecomment-6604352955
A correction to my review. I wrote that a deployment whose stored spec deploys only with the memory tuning overrides "would fail on its next redeploy". That's wrong: while memory tuning is enabled, the autoscaler applies its stored overrides on every reconcile, before the spec is deployed, so such a deployment redeploys fine. Only a spec made invalid by a changed operator default would fail on redeploy. So in the tuning case this check rejects every edit, including suspend, to a deployment that would deploy without problems. Without the webhook, the validation error also shows in the status from the first reconcile after the operator upgrade, even if nobody edits the resource. A release note doesn't cover that. Could the check take the tuning overrides into account? Skipping the check when memory tuning is enabled would also avoid it, but those deployments would then get the late deploy failure this PR fixes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
