applike-ss commented on code in PR #1163:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/1163#discussion_r4465845724
##########
helm/flink-kubernetes-operator/templates/_helpers.tpl:
##########
@@ -89,3 +89,10 @@ Supported values for .Values.logging.framework: "log4j2"
(default), "logback".
-Dlog4j.configurationFile=/opt/flink/conf/log4j-operator.properties
{{- end -}}
{{- end }}
+
+{{/*
+Create the name of the webhook certificate secret.
+*/}}
+{{- define "flink-operator.webhookCertSecretName" -}}
+{{- default (printf "%s-webhook-server-cert" .Release.Name)
.Values.webhook.certSecretName }}
Review Comment:
> anything external that referenced the old name breaks silently
The optional removal of the old secret is now documented. It might still be
used by other operators, leading to them remaining working when not removing
the secret.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
