gyfora opened a new pull request, #1248:
URL: https://github.com/apache/flink-kubernetes-operator/pull/1248
## What is the purpose of the change
The purpose is to make cleanup failure handle a bit more straightforward and
intuitive in case of persistent failures.
Cleanup failures are now propagated so that JOSDK retries them with its
regular backoff. On a retry, once the resource has been pending deletion for
longer than kubernetes.operator.resource.cleanup.finalizer.timeout (default
120m, measured from metadata.deletionTimestamp), the operator gives up: it
emits a Warning/CleanupFailed event and removes the finalizer.
The first failed attempt never gives up and a timeout of 0 disables giving
up altogether. If the JOSDK retries are exhausted before the timeout the
cleanup is rescheduled so that it keeps being retried.
This accepts that resources may be orphaned in exchange for keeping the
resource name redeployable. The status changes of a failed attempt are patched
before the error is rethrown so that they are not lost between retries.
## Verifying this change
New unit tests + manual tests in real k8s envs
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): no
- The public API, i.e., is any changes to the `CustomResourceDescriptors`:
no
- Core observer or reconciler logic that is regularly executed: no
## Documentation
- Does this pull request introduce a new feature? no
---
##### Was generative AI tooling used to co-author this PR?
- [ x ] Yes - Sonnet 5.5
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
