snuyanzin commented on code in PR #29724:
URL: https://github.com/apache/flink/pull/29724#discussion_r4473901269
##########
flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/runtime/utils/JoinReorderITCaseBase.java:
##########
@@ -377,6 +377,107 @@ public void testBushyTreeJoinReorder(boolean
isBushyJoinReorder)
assertEquals(query, expectedList);
}
+ @ParameterizedTest(name = "Is bushy join reorder: {0}")
+ @ValueSource(booleans = {true, false})
+ public void testJoinReorderWithFilterOnThreeTables(boolean
isBushyJoinReorder) {
+ setIsBushyJoinReorder(isBushyJoinReorder);
+ // The filter references all three tables, so no join of two of them
can apply it.
+ String query = "SELECT T1.b1, T2.b2, T3.c3 FROM T1, T2, T3 WHERE T1.b1
+ T2.b2 + T3.b3 = 4";
+
+ List<String> expectedList =
+ Arrays.asList("1,1,Hello", "1,1,Hello world", "1,2,Hi",
"2,1,Hi");
Review Comment:
nit
```suggestion
List.of("1,1,Hello", "1,1,Hello world", "1,2,Hi", "2,1,Hi");
```
here and in other places use `List.of`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
