nictownsend commented on code in PR #29761:
URL: https://github.com/apache/flink/pull/29761#discussion_r4482271937
##########
flink-runtime-web/web-dashboard/src/app/pages/task-manager/metrics/task-manager-metrics.component.spec.ts:
##########
Review Comment:
Type the mock `const mockDetail: TaskManagerDetail = {...}.` so that we
don't miss api changes in the future.
Currently, drift would not fail this test.
##########
flink-runtime-web/web-dashboard/src/app/interfaces/task-manager.ts:
##########
@@ -94,6 +94,8 @@ interface Metrics {
mappedCount: number;
mappedUsed: number;
mappedMax: number;
+ nettyShuffleMemorySegmentsAvailable: number;
Review Comment:
This never got flagged because the typescript linting is not checking all
the angular templates.
However, I tried that locally and it breaks many more files, I'll raise it
as a separate PR :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
