jnh5y opened a new pull request, #29772:
URL: https://github.com/apache/flink/pull/29772
## What is the purpose of the change
Backport of #28556 (449a0b1ce6bd4b70b78c07f173ec3e33cadf93f2) to
`release-2.4`, which already contains FLIP-574 metadata filter push-down
(FLINK-39421).
Per FLIP-574, metadata-only filter conjuncts should go only to
`applyMetadataFilters`, and conjuncts mixing physical and metadata columns
should stay as runtime filters. `PushFilterInCalcIntoTableSourceScanRule` did
not separate them, and both rules detected metadata fields with a count-based
check that misclassifies them once projection push-down has narrowed the scan.
With a watermark and an unselected physical column, this produced wrong results
in streaming.
## Brief change log
- Clean cherry-pick of the master commit; no conflicts.
## Verifying this change
Covered by the tests from the original PR
(`PushFilterInCalcIntoTableSourceRuleTest`,
`MetadataFilterInReadingMetadataTest`). Ran locally on this branch together
with the filter, projection and watermark push-down rule tests,
`TableSourceScanRestoreTest`, `ScanReuseTest` and `TableSourceTest`: 210 tests,
all passing.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): no
- The public API, i.e., is any changed class annotated with
`@Public(Evolving)`: no
- The serializers: no
- The runtime per-record code paths (performance sensitive): no
- Anything that affects deployment or recovery: JobManager (and its
components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
- The S3 file system connector: no
## Documentation
- Does this pull request introduce a new feature? no
- If yes, how is the feature documented? not applicable
---
##### Was generative AI tooling used to co-author this PR?
- [X] Yes (please specify the tool below)
Generated-by: Claude Opus 5.5
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
