Copilot commented on code in PR #271:
URL:
https://github.com/apache/flink-connector-jdbc/pull/271#discussion_r4491323683
##########
flink-connector-jdbc-core/src/test/java/org/apache/flink/connector/jdbc/datasource/connections/xa/SimpleXaConnectionProviderTest.java:
##########
@@ -43,6 +44,12 @@ public abstract class SimpleXaConnectionProviderTest
implements DatabaseTest {
private static final BooksTable TEST_TABLE = new BooksTable("XaTable");
private static final TransactionId TRANSACTION_BASE =
TransactionId.empty();
+ /** XA drivers return their own {@link Xid} type from recover(), so
compare by value. */
+ private static final Comparator<Xid> SAME_XID =
Review Comment:
`SAME_XID` is a bit ambiguous for a `Comparator<Xid>` constant. Consider
renaming to something more explicit like `XID_VALUE_COMPARATOR` (or similar) to
make its purpose clear at call sites (e.g., `.usingElementComparator(...)`).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
